Skip to content

move read transforms into "source" package as FeatureSources#74

Merged
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
tims:source_package
Jan 19, 2019
Merged

move read transforms into "source" package as FeatureSources#74
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
tims:source_package

Conversation

@tims
Copy link
Copy Markdown
Contributor

@tims tims commented Jan 14, 2019

First attempt #61

/donotmerge

/assign zhilingc

@tims
Copy link
Copy Markdown
Contributor Author

tims commented Jan 14, 2019

/hold

@tims
Copy link
Copy Markdown
Contributor Author

tims commented Jan 14, 2019

/assign pradithya

@tims
Copy link
Copy Markdown
Contributor Author

tims commented Jan 15, 2019

/hold cancel

I think this is ready to merge now. This introduces breaking changes, for the import spec for file based imports, the "type" changes like so:

type: file, options: { format: csv} ----> type: file.csv
type: file, options: { format: json} ----> type: file.json

@tims
Copy link
Copy Markdown
Contributor Author

tims commented Jan 18, 2019

@zhilingc @pradithya can you please review this?

@pradithya
Copy link
Copy Markdown
Collaborator

pradithya commented Jan 18, 2019

I think this is ready to merge now. This introduces breaking changes, for the import spec for file based imports, the "type" changes like so:

type: file, options: { format: csv} ----> type: file.csv
type: file, options: { format: json} ----> type: file.json

I think core will also need to change since it check for the import spec before submitting it, correct @zhilingc ?

@tims
Copy link
Copy Markdown
Contributor Author

tims commented Jan 18, 2019

updated core import spec validator class

@pradithya
Copy link
Copy Markdown
Collaborator

pradithya commented Jan 18, 2019

/lgtm

@zhilingc
Copy link
Copy Markdown
Collaborator

zhilingc commented Jan 19, 2019

Seems good. You're missing the license in some of the files though.
/approve

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jan 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b5e19bd into feast-dev:master Jan 19, 2019
@tims tims mentioned this pull request Jan 19, 2019
Merged
Yanson pushed a commit to Yanson/feast that referenced this pull request Jul 29, 2020
@algattik
Fix deadletter storage for docker-compose tests (feast-dev#74)
8cc92a8
tmihalac pushed a commit to tmihalac/feast that referenced this pull request Aug 12, 2024
@dmartinol
Merge pull request feast-dev#74 from dmartinol/remove_with_subclasses
dc0e847 
Removed with_subclasses option (it's the default and unique behavior)
Srihari1192 pushed a commit to Srihari1192/feast that referenced this pull request Mar 5, 2026
@ntkathole
Merge pull request feast-dev#74 from opendatahub-io/conflicts
d665758 
Merge remote-tracking branch 'upstream/master'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pradithya pradithya

@zhilingc zhilingc

Labels

approved lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tims @pradithya @zhilingc @feast-ci-bot